Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix breaking distraction free #49317

Conversation

corentin-gautier
Copy link
Contributor

@corentin-gautier corentin-gautier commented Mar 23, 2023

What?

This fixes an issue with the distraction free mode since changing the header overflow in #47177

Why?

Using overflow hidden on .interface-interface-skeleton__header prevent the mouse from hovering the header and triggering the display when in distraction free mode

How?

We move the styles to the .edit-post-header

Testing Instructions

  1. Open a Post or Page.
  2. Enter distraction free mode
  3. Move your mouse to the top of the screen
  4. The header should appear

Testing Instructions for Keyboard

Screenshots or screencast

@corentin-gautier
Copy link
Contributor Author

@ciampo @jasmussen Hi ! The changes that were made in #47177 prevent users from leaving the distraction free mode. (because of the overflow hidden on the header)

Could you take a look at this fix ?

@jasmussen jasmussen self-requested a review March 24, 2023 08:45
@jasmussen jasmussen assigned jasmussen and unassigned jasmussen Mar 24, 2023
@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Mar 24, 2023
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a prompt fix! In quick tests, this is working for me, and it seems harmless.

Before you merge, can you please test also in the site editor? The nested block there might be called edit-site-header.

GIF showing before, how the mouse cursor towards the top doesn't reveal the toolbar:

before

GIF of after, showing the toolbar appearing again:

after

@corentin-gautier
Copy link
Contributor Author

corentin-gautier commented Mar 24, 2023

@jasmussen Unless I'm mistaken the changes were only applied to the post editor. I took a look at the site editor but the DOM is widely different. I think we can merge this now and see later if we add the same behaviour on the site editor, what do you think ? Also I can't merge PRs ;)

@jasmussen
Copy link
Contributor

If both editors work, we can revisit, yes.

@corentin-gautier
Copy link
Contributor Author

@jasmussen Yes both work

@jasmussen jasmussen merged commit b31534c into WordPress:trunk Mar 27, 2023
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 27, 2023
@corentin-gautier corentin-gautier deleted the fix/distraction-free-scrollbar-gutter branch March 29, 2023 12:19
@ryanwelcher ryanwelcher added the [Package] Edit Post /packages/edit-post label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Post /packages/edit-post [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants