Add help text to Gallery Image Size control #49074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Copy
|
Well can we just remove the Image Size controls and add in the Image Dimension controls instead (if it is natural to do so)? "Select the Size of the Source image." Image Size are only related to resolution and that in itself is very confusing. |
|
Size Change: +21 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 28fc5c7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4418978125
|
We probably still need a control for choosing the resolution (i.e. "Image size") — for now at least.
You would see that the image is quite blurry. I'm just wanting to push for consistency with what we have today—not change how the controls work/what controls are available. |
|
Linking to Joen's comment here. Changing the "Image Size" title to become "Resolution" would be somewhat helpful fix. |
Perhaps so, but are we in agreement on changing the label from "Image Size" to "Resolution" across the board? cc @jasmussen
I don't think we need to print the word "resolution" twice. |
|
Adding the text below it = Adding the description you mentioned below it. |
jasmussen
approved these changes
Mar 15, 2023
I don't see a reason not to. It's not going to land in 6.2, so there's time to revert if for whatever reason this was a bad idea, but it seems vastly clearer to me. Overall though, what do you think about this design?
In terms of both verbiage and help text. I'm happy to revisit. |
@jasmussen I like it, though as you mentioned previously — I'm not sure the 25-100% are necessary/useful. And is there a select with the double values as a component in use already? |
This was referenced Mar 15, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In support of #48618 (comment), this small PR adds proper, consistent help text to the image size control for the Gallery block. Related: #48478
Why?
Consistency.
How?
Adds
Select the size of the source image.text via thehelpprop.Testing Instructions
Screenshots or screencast
Before:
After: