Lodash: Refactor away from _.set() in core-data
#48784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +1.61 kB (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
sgomes
approved these changes
Mar 10, 2023
| import setNestedValue from '../set-nested-value'; | ||
|
|
||
| describe( 'setNestedValue', () => { | ||
| it( 'should return the same object unmodified if path is an empty array', () => { |
There was a problem hiding this comment.
We should probably add some tests to ensure that it behaves correctly if input is not an object, e.g. null or undefined. I'll leave it to your judgement what "behaves correctly" should mean; lodash simply does nothing, but throwing an error may be a good alternative as well.
There was a problem hiding this comment.
Good point. Happy to alter it to do nothing as well - it's a simple condition. I've done it in 37cf182 where I also added some additional unit tests.
|
Flaky tests detected in 37cf182. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4404789928
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.set()from the@wordpress/core-datapackage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're introducing a utility function that serves as a replacement for
_.set()since this package works with various values and data structures, is very broadly used, and the original_.set()is used in a couple of places within the package.We're keeping the original logic that mutates the original object and preserving the original array behavior. We're also adding some tests to ensure everything works as expected.
Testing Instructions