Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP_Theme_JSON: sync indirect properties changes from core #48646

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Mar 1, 2023

What?

This PR syncs the Gutenberg class with the corresponding WordPress core changes.

Why?

By being in sync, future backport processes will be much easier.

Context:

How?

Copy the code from core to Gutenberg.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Flaky tests detected in 23d8bce.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4305527875
📝 Reported issues:

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting the backport @oandregal! 😄

This is still testing well for me (added define( 'DISALLOW_UNFILTERED_HTML', true ); locally, then tested that content and wide size, and block spacing values save in global styles) 👍

In case anyone's comparing this PR against the diff in WordPress/wordpress-develop#3742, this PR correctly uses the * @since 6.2.0 line in core, rather than the * @since 6.1.2 line from that PR's diff.

LGTM! ✨

@peterwilsoncc
Copy link
Contributor

this PR correctly uses the * @since 6.2.0 line in core, rather than the * @since 6.1.2 line from that PR's diff.

I think that was altered in a follow up commit so that core used the correct version. It seems 6.2 will be released first.

@andrewserong
Copy link
Contributor

I think that was altered in a follow up commit so that core used the correct version. It seems 6.2 will be released first.

Thanks for confirming!

@oandregal oandregal merged commit 8473276 into trunk Mar 2, 2023
@oandregal oandregal deleted the update/theme-json-indirect-properties branch March 2, 2023 08:23
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants