Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP_Theme_JSON_Gutenberg: update comments to be aligned with core, so backports are easier #48624

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

oandregal
Copy link
Member

What?

This PR updates the comments in the WP_Theme_JSON_Gutenberg class to be aligned with those of the corresponding core class.

Why?

This way the backports are easier. This is also a preparation for other PRs that update other parts of the class.

How?

Update the comments as per core's standards.

Testing Instructions

No manual testing is necessary.

@oandregal oandregal self-assigned this Mar 1, 2023
@oandregal oandregal added [Type] Developer Documentation Documentation for developers [Type] Code Quality Issues or PRs that relate to code quality labels Mar 1, 2023
@oandregal
Copy link
Member Author

oandregal commented Mar 1, 2023

There are some formatting I could not port because there is some lint difference between gutenberg & core codebases that is being worked on at #48603

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @oandregal!

@oandregal oandregal merged commit 2528053 into trunk Mar 1, 2023
@oandregal oandregal deleted the update/theme-json-comments branch March 1, 2023 11:55
@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Mar 1, 2023
@oandregal oandregal added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core and removed [Type] Developer Documentation Documentation for developers labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants