Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolTip: refactor using ariakit #48440

Merged
merged 57 commits into from
Sep 7, 2023
Merged

ToolTip: refactor using ariakit #48440

merged 57 commits into from
Sep 7, 2023

Commits on Aug 18, 2023

  1. Add ariakit dependency

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    73f1884 View commit details
    Browse the repository at this point in the history

  2. Initial creation of component

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    488f4c9 View commit details
    Browse the repository at this point in the history

  3. Add shortcut from legacy tooltip

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f69c2c8 View commit details
    Browse the repository at this point in the history

  4. Replace initial tests with legacy tooltip tests

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ab1bc4e View commit details
    Browse the repository at this point in the history

  5. Add anchor styles for tooltip placement

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    60ee046 View commit details
    Browse the repository at this point in the history

  6. Ensure tooltip renders only if one child is passed

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    16d2d12 View commit details
    Browse the repository at this point in the history

  7. Replace query with tooltip role and add user actions to ensure tests … 

    …complete
    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    1aebcf9 View commit details
    Browse the repository at this point in the history

  8. Remove forwarding refs to match legacy tooltip

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    0d20541 View commit details
    Browse the repository at this point in the history

  9. Add legacy positioning

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6d0eb21 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary code and add describedby id

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    cfb6c4a View commit details
    Browse the repository at this point in the history

  11. Replace cloneElement with Radix Slot

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    32d654f View commit details
    Browse the repository at this point in the history

  12. Replace emotion with sass

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5386d21 View commit details
    Browse the repository at this point in the history

  13. Update tests and types

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    53fd2cd View commit details
    Browse the repository at this point in the history

  14. Updated ariakit package and update-related props and types

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    adc88cb View commit details
    Browse the repository at this point in the history

  15. Remove radix-ui/react-slot related package changes

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b18b13a View commit details
    Browse the repository at this point in the history

  16. Add arrow to fix floating-ui errors

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    9ffb2c9 View commit details
    Browse the repository at this point in the history

  17. Replace zero value in temp fix to avoid NaN errors

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3e1fcca View commit details
    Browse the repository at this point in the history

  18. resolve test failures after package update

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    324ba78 View commit details
    Browse the repository at this point in the history

  19. Match legacy styles

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6f6d495 View commit details
    Browse the repository at this point in the history

  20. Hide tooltip onBlur to match legacy behavior

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    2eb848a View commit details
    Browse the repository at this point in the history

  21. Revert "resolve test failures after package update" 

    This reverts commit 9182f1e.
    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    64062b4 View commit details
    Browse the repository at this point in the history

  22. Prevent leaking by ensuring tooltip is hidden after each test

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e7088d1 View commit details
    Browse the repository at this point in the history

  23. Remove ‘overlay’ option to match legacy

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    a5c8ff3 View commit details
    Browse the repository at this point in the history

  24. hide on anchor interact to match legacy

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5c94f87 View commit details
    Browse the repository at this point in the history

  25. Temporarily replace placement with position for rollout

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e40a31c View commit details
    Browse the repository at this point in the history

  26. Update story after storybook upgrade

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    60e0ac3 View commit details
    Browse the repository at this point in the history

  27. Update descriptions in readme and types

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ca2fb50 View commit details
    Browse the repository at this point in the history

  28. Replace legacy tooltip with ariakit tooltip

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    89ad595 View commit details
    Browse the repository at this point in the history

  29. Add test with modal for new Esc feature

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    a415651 View commit details
    Browse the repository at this point in the history

  30. Error for multiple children but continue to render anchor without too… 

    …ltip
    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    2207553 View commit details
    Browse the repository at this point in the history

  31. Update snapshots

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    52fdc3d View commit details
    Browse the repository at this point in the history

  32. Update assertions in failing tests

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    800f258 View commit details
    Browse the repository at this point in the history

  33. Replace waitFor with findBy

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    875d9b5 View commit details
    Browse the repository at this point in the history

  34. Replace workaround with utility function

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    fef59d6 View commit details
    Browse the repository at this point in the history

  35. Clean up variables

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    60ff328 View commit details
    Browse the repository at this point in the history

  36. Update package-lock

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    56c353d View commit details
    Browse the repository at this point in the history

  37. Add cleanup to test where toBePositioned was used previously

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    4bd9455 View commit details
    Browse the repository at this point in the history

  38. Update Changelog

    @brookewp
    brookewp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ef7d837 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'trunk' into add/ariakit-tooltip 

    # Conflicts:
#	packages/components/CHANGELOG.md
    @brookewp
    brookewp committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    814ad63 View commit details
    Browse the repository at this point in the history

  2. Update event handling

    @brookewp
    brookewp committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    956bffd View commit details
    Browse the repository at this point in the history

  3. Fix failing test

    @brookewp
    brookewp committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    beb9a29 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Add cleanup for other components testing tooltip

    @brookewp
    brookewp committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8854357 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Remove Arrow workaround after floating-ui/core update

    @brookewp
    brookewp committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    26059b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'trunk' into add/ariakit-tooltip

    @brookewp
    brookewp authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    53a1f1c View commit details
    Browse the repository at this point in the history

  2. Refine test query to avoid conflict

    @brookewp
    brookewp committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    dc53c00 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Update tests based on feedback

    @brookewp
    brookewp committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    bb98faf View commit details
    Browse the repository at this point in the history

  2. remove unnecessary type and variable

    @brookewp
    brookewp committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    50b7f5d View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. Simplify by removing unnecessary logic and adding default value to po… 

    …sition prop
    @brookewp
    brookewp committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    75e4ea5 View commit details
    Browse the repository at this point in the history

  2. Add timeout to test for custom delay

    @brookewp
    brookewp committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    ed4c6aa View commit details
    Browse the repository at this point in the history

  3. Ensure anchor shows when Icon or multiple children

    @brookewp
    brookewp committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    cf59cd4 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Update types and README

    @brookewp
    brookewp committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6c54d5c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into add/ariakit-tooltip 

    # Conflicts:
#	packages/block-editor/src/components/color-palette/test/__snapshots__/control.js.snap
#	packages/components/CHANGELOG.md
#	packages/components/src/color-palette/test/__snapshots__/index.tsx.snap
#	packages/components/src/toggle-group-control/test/index.tsx
    @brookewp
    brookewp committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    45ba198 View commit details
    Browse the repository at this point in the history

  3. Update snapshots

    @brookewp
    brookewp committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    59fec6c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Remove type ignore after update in #54101

    @brookewp
    brookewp committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b43abd7 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Merge branch 'trunk' into add/ariakit-tooltip 

    # Conflicts:
#	packages/components/src/toggle-group-control/test/index.tsx
#	packages/components/src/tooltip/README.md
#	packages/components/src/tooltip/test/index.js
    @brookewp
    brookewp committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    869bdde View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into add/ariakit-tooltip

    @ciampo
    ciampo committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    968add1 View commit details
    Browse the repository at this point in the history

  3. Fix link control tests by querying explicitly for the spinner

    @ciampo
    ciampo committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    5761d79 View commit details
    Browse the repository at this point in the history