Global Styles: Display preset names via the tooltip #48304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Feb 22, 2023
|
Size Change: -1 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
When I first open the Popover the tooltip of the first item is shown. I think it should do that, right? 🤔 Screen.Recording.2023-02-22.at.11.10.36.AM.mov |
|
@ntsekouras, that's correct behavior. When you open the popover, the first element gets focus (this a11y feature), so the tooltip is displayed. |
|
Flaky tests detected in 21891fb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4240985211
|
ntsekouras
approved these changes
Feb 22, 2023
ntsekouras
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Global Styles: Display preset names via the tooltip * Use the preset slug as the component 'key'
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 6501bb7 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
ShadowIndicatorcomponent to display preset labels via tooltips.Why?
There was no visual indication of which preset the user is selecting without tooltips.
Testing Instructions
Screenshots or screencast