Plugin: Only apply the viewScript compat to core blocks #48268
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #45870
What?
This PR limits the functionality in
gutenberg_block_type_metadata_multiple_view_scripts()
to gutenberg-provided blocks only.Why?
This is done as
gutenberg_block_type_metadata_multiple_view_scripts()
relies upongutenberg_block_type_metadata_view_script()
which only operates on files present within Gutenberg.As noted within #45870 this causes WordPress 6.1 + Gutenberg plugin to be unable to use a block which has multiple items in the
viewScript
property.How?
The exclusion logic from
gutenberg_block_type_metadata_view_script()
is copied togutenberg_block_type_metadata_multiple_view_scripts()
.This ensures that any
viewScript
s that are from plugin-provided blocks fall through to the Core support.Testing Instructions
viewScript: [ "file:./index.js", "registered-script-handle", "script-handle-two" ]
Testing Instructions for Keyboard
Screenshots or screencast