Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18n issues in the block-parent-selector component. #48170

Closed
wants to merge 2 commits into from
Closed

Fix i18n issues in the block-parent-selector component. #48170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a64b407
i18n fixes
aristath Feb 17, 2023
6ac2c80
attempt to fix failing tests
aristath Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-parent-selector/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default function BlockParentSelector() {
onClick={ () => selectBlock( firstParentClientId ) }
label={ sprintf(
/* translators: %s: Name of the block's parent. */
__( 'Select %s' ),
__( 'Select "%s"' ),
blockInformation?.title
) }
showTooltip
Expand Down
12 changes: 6 additions & 6 deletions test/e2e/specs/editor/blocks/list.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ test.describe( 'List', () => {
await page.keyboard.type( 'one' );
await page.keyboard.press( 'Enter' );
await page.keyboard.type( 'two' );
await editor.clickBlockToolbarButton( 'Select List' );
await editor.clickBlockToolbarButton( 'Select "List"' );
await editor.transformBlockTo( 'core/paragraph' );

await expect.poll( editor.getEditedPostContent ).toBe(
Expand Down Expand Up @@ -352,7 +352,7 @@ test.describe( 'List', () => {
await page.keyboard.type( 'one' );
await page.keyboard.press( 'Enter' );
await page.keyboard.type( 'two' );
await editor.clickBlockToolbarButton( 'Select List' );
await editor.clickBlockToolbarButton( 'Select "List"' );
await editor.transformBlockTo( 'core/quote' );

await expect.poll( editor.getEditedPostContent ).toBe(
Expand Down Expand Up @@ -564,7 +564,7 @@ test.describe( 'List', () => {

test( 'should change the base list type', async ( { editor } ) => {
await editor.insertBlock( { name: 'core/list' } );
await editor.clickBlockToolbarButton( 'Select List' );
await editor.clickBlockToolbarButton( 'Select "List"' );
await editor.clickBlockToolbarButton( 'Ordered' );
await expect.poll( editor.getEditedPostContent ).toBe(
`<!-- wp:list {"ordered":true} -->
Expand All @@ -584,7 +584,7 @@ test.describe( 'List', () => {
await page.keyboard.press( 'Enter' );
await editor.clickBlockToolbarButton( 'Indent' );
await page.keyboard.type( '1' );
await editor.clickBlockToolbarButton( 'Select List' );
await editor.clickBlockToolbarButton( 'Select "List"' );
await editor.clickBlockToolbarButton( 'Ordered' );

await expect.poll( editor.getEditedPostContent ).toBe(
Expand Down Expand Up @@ -1108,7 +1108,7 @@ test.describe( 'List', () => {
await page.keyboard.type( '2' );
await page.keyboard.press( 'Enter' );
await page.keyboard.type( '3' );
await editor.clickBlockToolbarButton( 'Select List' );
await editor.clickBlockToolbarButton( 'Select "List"' );
await editor.clickBlockToolbarButton( 'Ordered' );

await expect.poll( editor.getEditedPostContent ).toBe(
Expand Down Expand Up @@ -1138,7 +1138,7 @@ test.describe( 'List', () => {
await page.keyboard.type( 'b' );
await page.keyboard.press( 'Enter' );
await page.keyboard.type( 'c' );
await editor.clickBlockToolbarButton( 'Select List' );
await editor.clickBlockToolbarButton( 'Select "List"' );
await editor.clickBlockToolbarButton( 'Unordered' );

await expect.poll( editor.getEditedPostContent ).toBe(
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/various/toolbar-roving-tabindex.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class ToolbarRovingTabindexUtils {
await this.page.keyboard.press( 'ArrowRight' );
await this.expectLabelToHaveFocus( currentBlockLabel );
await this.pageUtils.pressKeyWithModifier( 'shift', 'Tab' );
await this.expectLabelToHaveFocus( 'Select Group' );
await this.expectLabelToHaveFocus( 'Select "Group"' );
await this.page.keyboard.press( 'ArrowRight' );
await this.expectLabelToHaveFocus( currentBlockTitle );
}
Expand Down