Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Patterns: Add 8 new patterns to query loop block #47710

Closed
wants to merge 2 commits into from

Conversation

apeatling
Copy link
Contributor

Fixes #44140
Replaces #44163

What?

Include eight new query block patterns, including some more text based ones.

Why?

See #44140 and #44163 for the reasoning and backstory.

How?

Adds and registers the new query patterns in the 6.2 compatibility file.

Testing Instructions

  1. Insert a query block into a post
  2. Click the "Choose" button
  3. Scroll down the list and confirm you see the following patterns: "Post feed", "Post table", "Post list cards", "Two column text list", "Two column with tags", "Colorful full width posts", "Featured post with post list", "Featured post with more posts", "Post and date list".

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2023-02-02 at 10 11 54 AM

@apeatling apeatling added Needs Design Feedback Needs general design feedback. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Block] Query Loop Affects the Query Loop Block labels Feb 2, 2023
@apeatling apeatling self-assigned this Feb 2, 2023
@apeatling
Copy link
Contributor Author

We'll also be adding @richtabor's patterns in this PR #44140 (comment)

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Flaky tests detected in 15b62bb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4077526488
📝 Reported issues:

@richtabor
Copy link
Member

We should be able to load these in from the WordPress Pattern Directory, instead of hard-coding them in — yea? Like we did for the bundled header/footer patterns. What do you think?

@apeatling
Copy link
Contributor Author

Oh nice, I wasn't aware of that. That makes sense. So all we need to do is tag them as core and mark as 6.2 for them to show up? If that's the case, I can close this one out. 👍

@ntsekouras
Copy link
Contributor

We should be able to load these in from the WordPress Pattern Directory, instead of hard-coding them in

Yes.

Oh nice, I wasn't aware of that. That makes sense. So all we need to do is tag them as core and mark as 6.2 for them to show up? If that's the case, I can close this one out. 👍

Besides the above, we should also add the 'blockTypes' => array( 'core/query' ) meta in Pattern Directory.

@apeatling
Copy link
Contributor Author

apeatling commented Feb 3, 2023

@ryelle I saw you tagged patterns before to be included, are you able to help with the ones included here (plus these three)?

@ryelle
Copy link
Contributor

ryelle commented Feb 3, 2023

Yes, @richtabor will add them to the pattern directory and I'll follow up to add the correct meta values & get them published.

@apeatling
Copy link
Contributor Author

Closing this one out, thanks everyone!

@apeatling apeatling closed this Feb 3, 2023
@richtabor
Copy link
Member

So all we need to do is tag them as core and mark as 6.2 for them to show up? If that's the case, I can close this one out. 👍

Yup! We can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Query Loop block: Bundle more text focused patterns
4 participants