-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Library: Don't use methods with the 'gutenberg_' prefix #47649
Conversation
Flaky tests detected in df09832. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4065094619
|
@@ -382,7 +382,7 @@ function register_block_core_navigation_link() { | |||
* @param array $settings Default editor settings. | |||
* @return array Filtered editor settings. | |||
*/ | |||
function gutenberg_enable_animation_for_navigation_link_inspector( $settings ) { | |||
function block_core_navigation_link_enable_inspector_animation( $settings ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do this quick fix for now(renaming), but we need to see what we're going to do with __experimentalBlockInspectorAnimation
introduced here.
This setting is part of the auditing of experimental API for 6.2
. @artemiomorales is this something that we want to stabilize or exclude from 6.2
?
If the plan is to remain experimental, among the changes that will be needed, these functions(for the two other blocks) would need to be moved in different files and not remain here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you George!
What
PR replaces the
gutenberg_
prefix in block PHP files.Why?
These files are bundled with the package and should use methods also available in WP Core.
How?
Testing Instructions
CI tests should be green.
The navigation inspector animation testing instructions - #46342