Block Inspector: Make Settings tab the default #47592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +20 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
aaronrobertshaw
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
alexstine
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
@aaronrobertshaw This adds some level of consistency to the tabs. This tests well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47575
What?
Updates the Block Inspector tabs so they default to the Settings tab, and it is displayed before the Styles tab.
Why?
As the Block Inspector tabs have had more use we've found that the most often accessed controls are in fact within the Settings tab rather than the previous default, the Styles tab.
How?
Changes the order through which the Block Inspector tabs are rendered. The Settings tab will now appear before the Styles tab. This means when a block doesn't have the List View tab but still has more than just the Advanced panel to display in the Settings tab, the Settings tab will be the default.
Next Steps
With the Settings tab being the default, we probably should remove the filters added to the Navigation Link and Submenu blocks which disabled tabs so their more important settings would appear immediately in the sidebar.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2023-01-31.at.3.21.44.pm.mp4