Restore the navigation menus in the site editor #47485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Site Editor
|
Thanks for fast work! |
|
Size Change: -498 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in efdaea9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4023313819
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #46995 the experimental flag for the Navigation Off Canvas editor has been removed but one check has been left out in the code base causing the navigation menu to not appear in the sidebar of the site editor.
I'm not removing all the remaining artifacts of the experimental flag which fixes the site editor sidebar as well. This PR also removes the navigation sidebar within the edit mode as it's now replaced with the one in the browse mode sidebar.
Testing Instructions
1- Check that the navigation menu item appears in the left sidebar of the site editor but not within the edit mode.