-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates some spacing + dimensions in the Site Hub #47120
Conversation
Size Change: +24 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Flaky tests detected in 651ee14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3904413262
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 assuming we want to reduce the size of the site icon (which can reduce its visibility depending on what is set there)
This change did involve increasing the W button footprint to 64px in view mode, but that was essential unless we want to reduce the footprint of the whole button down to 32px which seemed like a usability trade-off. It resizes back to 60px in edit mode, and seems to work fine.