Revert "[Site Editor]: Add default white background for themes with no background color set"
#46893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
noahtallen
added
the
Backport to Gutenberg Minor Release
|
We ended up hot-fixing this solution on our end, so we won't need this change. However, it's definitely still fragile/buggy! |
talldan
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #46314
We're running a very large deployment of Gutenberg (v14.8.4 at this point), and unfortunately this has been causing issues! I know this is on the radar already, but I think this ended up breaking more things than it fixed.
Reasoning: most themes do provide styles which set the background color correctly in the editor -- at least, all of the themes we have been testing with do. In this scenario, the change overwrites those styles even for block-based themes, meaning the editor background color doesn't work at all for many themes. (Partly because of specificity and style loading order.) I think this would also break things if the styles were applied at a different level.
At the same time, I'm not sure how many themes people use wouldn't have editor styles set up correctly. At any rate, it seems like there would be higher usage of themes which are broken with this change rather than the other way around, assuming that the most popular themes set the background color correctly.
IMO, the fix needs to be applied much higher in the DOM -- why is "a dark color... applied to the background" in the first place?