Synchronize the sidebar state in the url #46433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Size Change: +55 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 9, 2022
youknowriad
force-pushed
the
sync/sidebar-in-url
branch
2 times, most recently
from
f0e9de9
to
45bdb9a
Compare
youknowriad
force-pushed
the
sync/sidebar-in-url
branch
from
45bdb9a
to
87166aa
Compare
|
When I exit edit mode, I now land in the right section, but I still expect the current template to be selected instead of the back button? |
ellatrix
approved these changes
Dec 12, 2022
It should be the case? |
|
Unrelated: would be nice to be able to click a preview to edit it. |
|
@ellatrix You mean "focused" maybe? It's not really clear to me what should be focused, I guess right now, it's just the first element in the sidebar. |
|
@youknowriad This is what I'm seeing:
|
I know "double clicking" was being considered, but I also know that the idea is that ultimately, you'd be able to actually navigate the site when you click the preview. |
|
@ellatrix That's because you've clicked "browse all templates" which navigates to another page (the browse all templates page), so this new page is what is selected on the sidebar, if you click the "w" button instead, your current template will be selected. Potentially, we should consider updating what the "browse all templates" does. Maybe it shouldn't go to that view (all templates) but instead just opens the sidebar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #45100
What?
This PR does two things:
Testing Instructions
1- Navigate the site editor
2- Notice that when you exit the "edit" mode, you're back in the same state of the sidebar that was before entering the "edit" mode.