Inserter: Pattern title tooltip #46419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Inserter
ntsekouras
requested review from
javierarce,
youknowriad,
jameskoster,
jasmussen and
carolinan
ntsekouras
commented
Dec 9, 2022
| blocks={ blocks } | ||
| viewportWidth={ viewportWidth } | ||
| /> | ||
| { ! showTooltip && ( |
There was a problem hiding this comment.
Besides this check, the CompositeItem changes are whitespace ones.
|
Size Change: +1.3 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 9, 2022
youknowriad
reviewed
Dec 9, 2022
packages/block-editor/src/components/block-patterns-list/index.js
Outdated
Show resolved
Hide resolved
|
Ship as you wish :) |
ntsekouras
changed the title
ryanwelcher
changed the title
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #45595
#45595 discusses the visibility of the patterns title in the inserter list, which is now hidden.
That is a small PR to try having
Toolitpto show the titles in the inserter patterns list. In mobile inserter patterns list and inpatterns explorerthe titles remain visible as before(see @javierarce' s comment)Testing Instructions
Screenshots or screencast
Screen.Recording.2022-12-09.at.9.27.04.AM.mov