Query: Remove color block supports #46147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Package] Block library
|
Size Change: +301 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
aaronrobertshaw
force-pushed
the
refactor/query-block-color-supports
branch
from
698d39d
to
9022fcf
Compare
aaronrobertshaw
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
aaronrobertshaw
changed the title
|
This looks like a safer approach than the previous one - there is still the potential for it to be a breaking change if themes are targeting children based on them being direct children of the query block, but that is a much lesser risk than problems with adding color to all children, and 🤞will be a reasonable small subset of usage. Will give it a full review next week. |
glendaviesnz
added
the
Needs Dev Note
glendaviesnz
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Worked as advertised for me:
✅ Query blocks with color were migrated to a nested group with color attached
✅ Deprecation fixture tests ran successfully
✅ Color option gone from new query blocks but available on post template block
I added the Needs dev note flag as we should alert people to the potential new dom structure for migrated blocks.
ntsekouras
reviewed
Dec 13, 2022
|
Query blocks with colors support styles applied directly to them should be infrequent enough that a simple note in the Block Editor misc dev notes should suffice. Dev NoteStarting from WordPress 6.2, the Query block will no longer opt into color block supports. Existing Query blocks with set colors will be migrated. This may potentially involve a new DOM structure due to an introduced inner Group block to which the previously set colors will be moved. For more info, see #46147. |
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46472
Related:
What?
Removes the Query block's color supports, moving them to the inner blocks.
Note: This could be a potentially breaking change due to the potential introduction of a wrapping Group block to enable reapplying the prior Query block colors.
Why?
The Query block is to be a "settings only" block. Applying the colors at such a high level has inconsistent results as well.
This direction for the Query block was identified through feedback on the block inspector tabs experiment introduced in #45005
How?
Alternative Approach Tried: Reapply colors to all inner blocks
This approach fell short in a couple of key ways:
It would have the benefit of not introducing additional markup though. In trialling this approach the lack of new markup doesn't make up for its failure to maintain colors.
Testing Instructions
npm run test:unit test/integration/full-content/full-content.test.jsExample Deprecated Query Blocks
The following query blocks have a mixed of applied color support styles, inner blocks, or no customization.
Screenshots or screencast
Screen.Recording.2022-12-08.at.3.34.41.pm.mp4