TabPanel: fix the exhaustive-deps
warning
#45660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the
exhaustive-deps
warning in theTabPanel
componentRelated to:
TabPanel
to passexhaustive-deps
#44935 (a previous attempt at fixing theexhaustive-deps
warning)TabPanel
hook)Why?
Because #41166
How?
handleTabSelection
to the list ofuseEffect
dependencieshandleTabSelection
inuseCallback
Testing Instructions
handleTabSelection
to fire more often than before — when smoke testing, pay particular attention to consumers ofTabPanel
passing theonSelect
prop, and how frequently theonSelect
callback gets called after the changes from this PR.