Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: fix useCx story to satisfy exhaustive-deps eslint rule #45614

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Components: fix useCx story to satisfy exhaustive-deps eslint rule #45614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff7e21c
move `eslint-ignore-*` to the correct line
flootr Nov 8, 2022
41a2733
update CHANGELOG.md
flootr Nov 8, 2022
a8e0678
Merge branch 'trunk' into refactor/useCx-story-exhaustive-deps
flootr Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- `withNotices`: Update to pass `exhaustive-deps` eslint rule ([#45530](https://github.com/WordPress/gutenberg/pull/45530)).
- `ItemGroup`: Update to pass `exhaustive-deps` eslint rule ([#45531](https://github.com/WordPress/gutenberg/pull/45531)).
- `Draggable`: Convert to TypeScript ([#45471](https://github.com/WordPress/gutenberg/pull/45471)).
- `useCx`: fix story to satisfy the `react-hooks/exhaustive-deps` eslint rule ([#45614](https://github.com/WordPress/gutenberg/pull/45614))

### Experimental

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/utils/hooks/stories/use-cx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ const Example = ( { serializedStyles, children } ) => {
const ExampleWithUseMemoWrong = ( { serializedStyles, children } ) => {
const cx = useCx();
// Wrong: using 'useMemo' without adding 'cx' to the dependency list.
// eslint-disable-next-line react-hooks/exhaustive-deps
const classes = useMemo(
() => cx( serializedStyles ),
// eslint-disable-next-line react-hooks/exhaustive-deps
[ serializedStyles ]
);
return <span className={ classes }>{ children }</span>;
Expand Down