-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental list view duplicate for use in navigation list view experiment #45544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
draganescu
changed the base branch from
trunk
to
add/navigation-off-canvas-edit-experiment
November 4, 2022 10:03
draganescu
changed the title
experiment/duplicate of list view
Experimental list view duplicate for use in navigation list view experiment
Nov 4, 2022
Size Change: +4.63 kB (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
draganescu
added
[Feature] UI Components
Impacts or related to the UI component system
[Type] Experimental
Experimental feature or API.
labels
Nov 4, 2022
Base automatically changed from
add/navigation-off-canvas-edit-experiment
to
trunk
November 7, 2022 21:19
scruffian
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
scruffian
force-pushed
the
experiment/duplicate-of-list-view
branch
from
November 7, 2022 21:51
dc05ff9
to
7683fca
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a spin off from #44534.
It introduces a duplicated list view component and exports it as experimental.
To do:
Why?
This is created so that UX chaneges can be iterated on feaster inside of the experiment.
How?
Copy paste the list view component.
Changed name.
Export changed name.
Document changed name.
The only new thing is renaming the top most component to __ExperimentalOffCanvasEditor and exporting it. All else is identical in this PR to __ExperimentalListView
Testing Instructions
Check the diff.
Screenshots or screencast
N/A