-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar: Add slot above tabs for items applying to block as a whole #45437
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
510b3e6
Add new block information slot
aaronrobertshaw b322536
Move query blocks new post link to new slot
aaronrobertshaw 541f769
Rename slot and inspector controls group
aaronrobertshaw 81e582a
Render new post link directly instead of via filter
aaronrobertshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
packages/block-library/src/query/edit/inspector-controls/create-new-post-link.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { createInterpolateElement } from '@wordpress/element'; | ||
import { addQueryArgs } from '@wordpress/url'; | ||
|
||
const CreateNewPostLink = ( { | ||
attributes: { query: { postType } = {} } = {}, | ||
} ) => { | ||
if ( ! postType ) return null; | ||
const newPostUrl = addQueryArgs( 'post-new.php', { | ||
post_type: postType, | ||
} ); | ||
return ( | ||
<div className="wp-block-query__create-new-link"> | ||
{ createInterpolateElement( | ||
__( '<a>Create a new post</a> for this feed.' ), | ||
// eslint-disable-next-line jsx-a11y/anchor-has-content | ||
{ a: <a href={ newPostUrl } /> } | ||
) } | ||
</div> | ||
); | ||
}; | ||
|
||
export default CreateNewPostLink; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would make more sense directly below
BlockCard
component or we could even consider adding this insideBlockCard
. I think I had seen some use cases for enhancing theBlockCard
before, for example adding html(links) like here. The way I had seen others doing it was by modifying the block's description with filters and we used to allow that, even if it should be just a string.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all we want is to render some extra text or links, moving the slot above the block variations makes sense to me.
I was under the impression that we didn't want to update the BlockCard for the moment, and this new slot would be for "adding something relevant to the block as a whole". That "something" sounded like it could possibly be more than a simple link.
With that flexibility, we get the potential for the slot to be abused though.