Post editor: Rename view to Preview #45074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -23 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
annezazu
added
the
Backport to WP 6.7 Beta/RC
|
cc @ockham and @michalczaplinski - can you all please backport this for 6.1? |
|
I may have missed updating some files for the tests, it wasn't entirely clear, but I think #45078 would fix them. |
I see you already added the "Backport to WP Beta/RC" label 😄 Since there's no PHP code in this PR, that's enough for having it slated for next Monday's triage session and Thursday's RC3 👍 |
|
I think this PR broke the E2E tests. 🤔 https://github.com/WordPress/gutenberg/actions/runs/3275466565/jobs/5390351692 I'm not sure #45078 addresses them all since they're failing there too. I'll throw up a PR to make sure. 🍺 |
|
Thank you! Anything you can do to help repair the lovely e2e tests would be great too (including just reverting this if we need to). |
ramonjd
added a commit
that referenced
this pull request
Oct 19, 2022
ramonjd
added a commit
that referenced
this pull request
Oct 19, 2022
* Update E2E test after Post editor: Rename view to Preview (#45074) * Follow ups * Mucho linto
ockham
pushed a commit
that referenced
this pull request
Oct 25, 2022
* Update E2E test after Post editor: Rename view to Preview (#45074) * Follow ups * Mucho linto
ockham
pushed a commit
that referenced
this pull request
Oct 25, 2022
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 4e661cd |
ockham
removed
the
Backport to WP 6.7 Beta/RC
This was referenced Oct 25, 2022
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 25, 2022
Package updates for bug and regression fixes: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. See #56467. Built from https://develop.svn.wordpress.org/trunk@54693 git-svn-id: http://core.svn.wordpress.org/trunk@54245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 25, 2022
Package updates for bug and regression fixes: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. See #56467. Built from https://develop.svn.wordpress.org/trunk@54693 git-svn-id: https://core.svn.wordpress.org/trunk@54245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Oct 25, 2022
Package updates for bug and regression fixes since 6.1 RC 2: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. Reviewed by desrosj, hellofromTonya, SergeyBiryukov. Merges [54693] to the 6.1 branch. See #56467. git-svn-id: https://develop.svn.wordpress.org/branches/6.1@54694 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 25, 2022
Package updates for bug and regression fixes since 6.1 RC 2: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. Reviewed by desrosj, hellofromTonya, SergeyBiryukov. Merges [54693] to the 6.1 branch. See #56467. Built from https://develop.svn.wordpress.org/branches/6.1@54694 git-svn-id: http://core.svn.wordpress.org/branches/6.1@54246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
Package updates for bug and regression fixes: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54693 602fd350-edb4-49c9-b593-d223f7449a82
This was referenced Mar 6, 2023
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
Package updates for bug and regression fixes: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. See #56467. Built from https://develop.svn.wordpress.org/trunk@54693 git-svn-id: http://core.svn.wordpress.org/trunk@54245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
Package updates for bug and regression fixes since 6.1 RC 2: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. Reviewed by desrosj, hellofromTonya, SergeyBiryukov. Merges [54693] to the 6.1 branch. See #56467. Built from https://develop.svn.wordpress.org/branches/6.1@54694 git-svn-id: http://core.svn.wordpress.org/branches/6.1@54246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the "View" button to say "Preview" in the post editor.
Before:
After: