Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the ColorPalette component to TypeScript #44632

Merged
merged 43 commits into from
Oct 26, 2022
Merged

Convert the ColorPalette component to TypeScript #44632

merged 43 commits into from
Oct 26, 2022

Commits on Oct 2, 2022

  1. Convert the ColorPalette component to TypeScript 

        There are some ts-ignore statements
    that would be good to remove.
    @kienstra
    kienstra committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    b9b3fbc View commit details
    Browse the repository at this point in the history

  2. Correct the PR number in the CHANGELOG

    @kienstra
    kienstra committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    2521cae View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Apply Marco's suggestion to remove ts-ignore comments 

    Destructure props int constants after the function
signature, not inside it.
    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    54af17c View commit details
    Browse the repository at this point in the history

  2. Replace complex type with ReactNode, thanks to Marco's suggestion

    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c9f5d8a View commit details
    Browse the repository at this point in the history

  3. Apply Marco's suggestions for TS verbatim 

    WordPress#44632 (review)
    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    4a602dd View commit details
    Browse the repository at this point in the history

  4. Prevent an error from colors possibly being undefined 

    Types of property 'colors' are incompatible.
  Type 'Colors | undefined' is not assignable to type '(Color | MultipleColors)[]'.
    Type 'undefined' is not assignable to type '(Color | MultipleColors)[]'.
    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    7fe648e View commit details
    Browse the repository at this point in the history

  5. Rename Color and MultipleColors to ColorObject and PaletteObject

    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    fcd61ee View commit details
    Browse the repository at this point in the history

  6. Alphabetize the imports again

    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    4629f7c View commit details
    Browse the repository at this point in the history

  7. Remove another needless ts-ignore comment

    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    6ee6987 View commit details
    Browse the repository at this point in the history

  8. Revert "Prevent an error from colors possibly being undefined" 

    This reverts commit 7fe648e.
    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    6a7c211 View commit details
    Browse the repository at this point in the history

  9. Make colors allow undefined

    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    3fc9fa2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'trunk' into update/color-palette-component-ts

    @kienstra
    kienstra committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    1ece323 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Make actions optional, which I forgot before

    @kienstra
    kienstra committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    a07c43f View commit details
    Browse the repository at this point in the history

  2. Merge in trunk, resolve conflict 

    There was a conflict in CHANGELOG.md,
but I kept both edits.
    @kienstra
    kienstra committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    90efcd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Commit Marco's changes, including a named export

    @kienstra
    kienstra committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c420232 View commit details
    Browse the repository at this point in the history

  2. Add default tags, thanks to Marco's idea

    @kienstra
    kienstra committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    9b770d3 View commit details
    Browse the repository at this point in the history

  3. Apply Marco's suggestion to remove ts-ignore 

    Add 'as CSSProperties'
to remove the need for ts-ignore
    @kienstra
    kienstra committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ea5b1f3 View commit details
    Browse the repository at this point in the history

  4. Apply Marco's suggestions, creating UnforwardedColorProps 

    The jsx example might not be right.
Also, I added a description for the component
in the JS DocBlock, as there wasn't one in README.md.
But maybe that's not right.
    @kienstra
    kienstra committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    a79c187 View commit details
    Browse the repository at this point in the history

  5. Merge in trunk, resolve conflict 

    The only conflict was trivial, in
components/CHANGELOG.md
    @kienstra
    kienstra committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e729c8f View commit details
    Browse the repository at this point in the history

  6. Fix a linting error, remove needless className

    @kienstra
    kienstra committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    25e0ba2 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/stories/index.tsx

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    8001f14 View commit details
    Browse the repository at this point in the history

  2. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/types.ts

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    e793921 View commit details
    Browse the repository at this point in the history

  3. Rename test/index.js to test/indes.tsx, mv snapshot

    @kienstra
    kienstra committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    53c8beb View commit details
    Browse the repository at this point in the history

  4. Add types to test/index.tsx

    @kienstra
    kienstra committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    06f7c4e View commit details
    Browse the repository at this point in the history

  5. Renamce styles.js to styles.ts

    @kienstra
    kienstra committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    293fafe View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/types.ts

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    0af93a8 View commit details
    Browse the repository at this point in the history

  2. Revert "Add types to test/index.tsx" 

    This reverts commit 06f7c4e.
    @kienstra
    kienstra committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    d77ca5b View commit details
    Browse the repository at this point in the history

  3. Paste Marco's description verbatim 

    WordPress#44632 (review)
    @kienstra
    kienstra committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    626b25d View commit details
    Browse the repository at this point in the history

  4. Copy props verbatim from types.ts into README.md

    @kienstra
    kienstra committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    905c40e View commit details
    Browse the repository at this point in the history

  5. Update the JSDoc description to be the same as the README.md description 

    The usage example was already the same
as in the README.md
    @kienstra
    kienstra committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    eee647c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'trunk' into update/color-palette-component-ts

    @kienstra
    kienstra committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    0bb6561 View commit details
    Browse the repository at this point in the history

  7. Remove extra entry for Tooltip 

    I think I added this
when merging in trunk and resolving the conflicts.
    @kienstra
    kienstra committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    73c17ea View commit details
    Browse the repository at this point in the history

  8. Move the CHANGELOG entry up, to Unreleased

    @kienstra
    kienstra committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    bb25a62 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Move Usage section to the top of the README. remove experimental prop… 

    …s from README
    @kienstra
    kienstra committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4fd5d9c View commit details
    Browse the repository at this point in the history

  2. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/README.md

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    d65a832 View commit details
    Browse the repository at this point in the history

  3. Remove the example of the full props

    @kienstra
    kienstra committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    29984c0 View commit details
    Browse the repository at this point in the history

  4. Change the props format to match CONTRIBUTING.md 

    https://github.com/WordPress/gutenberg/blob/a42805e157f6c6933f4ef7cabcfc87fa3af81aea/packages/components/CONTRIBUTING.md#readme-example
    @kienstra
    kienstra committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    988e940 View commit details
    Browse the repository at this point in the history

  5. Merge in trunk, resolve conflict 

    Resolve trivial conflict
in CHANGELOG.md.
    @kienstra
    kienstra committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    193fae3 View commit details
    Browse the repository at this point in the history

  6. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/stories/index.tsx

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2df05c6 View commit details
    Browse the repository at this point in the history

  7. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/types.ts

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    e88cf95 View commit details
    Browse the repository at this point in the history

  8. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/types.ts

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    eb8c5c3 View commit details
    Browse the repository at this point in the history

  9. Commit Marco's suggestion: Update packages/components/src/color-palet… 

    …te/types.ts

Co-authored-by: Marco Ciampini <[email protected]>
    @kienstra @ciampo
    kienstra and ciampo authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    a2aa2e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Merge branch 'trunk' into update/color-palette-component-ts

    @ciampo
    ciampo authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f741e4b View commit details
    Browse the repository at this point in the history