Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleGroupControl: Refactor to handle de-selection and multiple selections #44168

Closed
wants to merge 13 commits into from
Closed

ToggleGroupControl: Refactor to handle de-selection and multiple selections #44168

wants to merge 13 commits into from

Commits on Oct 19, 2022

  1. Extract radio logic to subcomponent

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1307c98 View commit details
    Browse the repository at this point in the history

  2. Fix wrong types 

    - otherProps are forwarded to div, not `input`
- ToggleGroupControl should not accept a `disabled` prop, but it was included via the FormElementProps type
    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    80047b5 View commit details
    Browse the repository at this point in the history

  3. Remove borderless prop

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    872fcdf View commit details
    Browse the repository at this point in the history

  4. Remove multiple prop

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    3554899 View commit details
    Browse the repository at this point in the history

  5. Add deselectability

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    872a95d View commit details
    Browse the repository at this point in the history

  6. Clean up

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    06aec52 View commit details
    Browse the repository at this point in the history

  7. Rename buttonActive → buttonPressed

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d54e8ef View commit details
    Browse the repository at this point in the history

  8. Fix up button styles 

    - Removed unused `separatorActive`
- Don't lighten button when deselectable
    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e186644 View commit details
    Browse the repository at this point in the history

  9. Adjust focus styles

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    f09c95e View commit details
    Browse the repository at this point in the history

  10. Remove invalid style

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0cda2cf View commit details
    Browse the repository at this point in the history

  11. Update snapshots

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b41dc72 View commit details
    Browse the repository at this point in the history

  12. Add tests

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    34f56c4 View commit details
    Browse the repository at this point in the history

  13. Add ToggleMultipleGroupControl

    @mirka
    mirka committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    201bb03 View commit details
    Browse the repository at this point in the history