Components: refactor NavigationMenu to ignore exhaustive-deps
#44090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
added
[Type] Code Quality
chad1008
changed the title
Navigation/Menu to ignore exhaustive-depsNavigationMMenu to ignore exhaustive-deps
chad1008
changed the title
NavigationMMenu to ignore exhaustive-depsNavigationMenu to ignore exhaustive-deps
44 tasks
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Sep 12, 2022
chad1008
force-pushed
the
refactor/navigation-menu-exhaustive-deps
branch
from
47d6293
to
9ecc7ac
Compare
ockham
added
the
Backport to WP 6.7 Beta/RC
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 32d0778 |
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
ockham
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the NavigationMenu components/hooks to ignore the
exhaustive-depseslint rule.Why?
Similar to #41639, because
Navigatoris preferred overNavigation, it doesn't make sense to invest time in refactoring the latter component. IfNavigationis used more in the future, this can be revisited.How?
Identified the two warnings and added inline ignore statements
Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/navigation/menu