List: make allowedBlocks setting a constant #44011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Performance
Mamaduka
approved these changes
Sep 9, 2022
|
Size Change: +13 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
I thought this was resolved in #30311. But I think it's still a good practice to pass |
|
Hm, yes, I wonder if that's still working. |
|
It does improve a bit some perf metrics for the post editor (I guess that's where we use the large-post data): Left is this branch, right is trunk, see:
|
|
@ellatrix, I did a quick test for the memoization method introduced in #30311, and it should be working correctly. Here's a CodeSandbox if anyone is interested - https://codesandbox.io/s/memoize-setting-in-child-0t547m |
| @@ -128,7 +129,7 @@ export default function Edit( { attributes, setAttributes, clientId, style } ) { | |||
| ...( Platform.isNative && { style } ), | |||
| } ); | |||
| const innerBlocksProps = useInnerBlocksProps( blockProps, { | |||
| allowedBlocks: [ 'core/list-item' ], | |||
| allowedBlocks: ALLOWED_BLOCKS, | |||
There was a problem hiding this comment.
The whole object passed as the second arg of this useInnerBlocksProps() call could be a constant, couldn't it?
There was a problem hiding this comment.
It could be, but I think we shallow compare it anyway, so there would be no point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Settings are shallowly checked, so passing a new array on every render will cause the settings to be updated on every render.
Ideally this should be taken care of under the hood so blocks don't have to worry about this.
Why?
How?
Testing Instructions
Screenshots or screencast