Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading: Add missing typography support #44003

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography support to the Heading block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing text-decoration typography support.

Testing Instructions

  1. Edit a post, add a Heading block, and select it
  2. Check that the text-decoration control is now available
  3. Ensure text decoration is applied both in the editor and frontend
  4. Test styling via theme.json (Note: Text decoration isn't available in Global Styles)

Example theme.json snippet:

			"core/heading": {
				"typography": {
					"textDecoration": "underline"
				}
			},

Screenshots or screencast

Adds text decoration support for more consistency across typography design tools.
@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Heading Affects the Headings Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Sep 9, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Sep 9, 2022
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me:
✅ In editor and frontend
✅ When added to theme.json showed in editor and frontend

@aaronrobertshaw aaronrobertshaw merged commit 7a6d952 into trunk Sep 12, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-support-to-heading branch September 12, 2022 05:29
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 12, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants