Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query No Results: Add typography supports #43551

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds typography supports to the Query No Results block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into all typography supports.
  • Makes font size control displayed by default as per majority of blocks currently.

Testing Instructions

  1. In the site editor, edit a template with a Query block, and add content to its No Results block.
  2. Adjust the Query settings so that no posts will be matched.
  3. Navigate to Global Styles > Blocks > Query No Results > Typography.
  4. Experiment with typography styles and ensure they are applied to the No Results block in the preview.
  5. Save and confirm styles on the frontend.
  6. Select the Query No Results block within the preview.
  7. On the Block tab of the Settings sidebar, test the typography controls for the individual block.
  8. Reset the individual and global styles for the No Results block.
  9. Add typography styles for the core/query-no-results block to your theme.json and confirm they work.

Example theme.json snippet:

			"core/query-no-results": {
				"typography": {
					"fontWeight": "100",
					"textTransform": "uppercase"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.5.43.58.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 24, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 24, 2022
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme.json, block and global style settings work well.

@aaronrobertshaw aaronrobertshaw force-pushed the add/typography-support-to-query-no-results branch from dec98f9 to 1be28e7 Compare August 26, 2022 09:36
@aaronrobertshaw aaronrobertshaw merged commit b4f6baa into trunk Aug 26, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/typography-support-to-query-no-results branch August 26, 2022 11:03
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 26, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants