Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use str_starts_with #43371

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Use str_starts_with #43371

merged 2 commits into from
Aug 18, 2022

Conversation

aristath
Copy link
Member

What?

The str_starts_with function is available is PHP 8+. A polyfill for the function exists in WP 5.9+, so we should use that function instead of previous implementations.

Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aristath aristath merged commit ed63923 into trunk Aug 18, 2022
@aristath aristath deleted the use/str_starts_with-00 branch August 18, 2022 12:42
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
This was referenced Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants