Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Navigation Link: Add missing typography supports #43344

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography support to the Post Navigation Link block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing typography supports.

Testing Instructions

  1. Edit a post, add a Previous Post or Next Post link, and select it.
  2. Confirm the text-decoration control is available.
  3. Test text decoration can be applied and displays correctly within the editor and on the frontend.
  4. Clear the text decoration style from the block.
  5. Style the Post Navigation Link block via theme.json to add a text-decoration style.
  6. Reload editor and confirm the theme.json style applies correctly as well as on the frontend.

Example theme.json snippet.

			"core/post-navigation-link": {
				"typography": {
					"textDecoration": "line-through"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-18.at.11.57.36.am.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Navigation Link Affects the Post Navigation Link Block [Feature] Typography Font and typography-related issues and PRs labels Aug 18, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 18, 2022
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me:
✅ Text decoration was available in editor inspector controls for block and applying showed in editor and frontend
✅ Adding setting to theme.json was applied in editor and frontend

@aaronrobertshaw aaronrobertshaw merged commit 1d944a1 into trunk Aug 23, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-post-navigation-link branch August 23, 2022 01:16
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 23, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Navigation Link Affects the Post Navigation Link Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants