PHPUnit: Let PHPUnit Polyfills match PHPUnit version #43334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43333
What?
Lets PHPUnit Polyfills match the PHPUnit version to the PHP version.
Before this PR, the Gutenberg tests run on PHP 7.4 and use PHPUnit 6.5. However, the matching PHPUnit version should be PHPUnit 9.
This PR uses PHPUnit Polyfills to set the PHPUnit version, rather than setting the version in the
composer.json
file and locking it in the.lock
file.Why?
Reasons:
How?
See the set up instructions in this Dev Note.
The changes are:
composer.json
.composer.lock
file. Why? To allow for cross-version PHP testing.composer.lock
file. Why? One.lock
file locks the CI into only those versions specified in that.lock
file, thus blocking the ability to do cross-version PHP testing.CI updates to run cross-version PHP testing is not included in the scope of this PR. A future PR will be coming. Note: WordPress Core runs the PHP test suite on all of the supported versions.