Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Edit Link: Add missing typography support #43263

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw commented Aug 16, 2022

Related:

What?

  • Adds missing text-decoration support to the Comment Edit Link.
  • Makes font size a default control to match other text related blocks

Why?

While there might not be a lot of value in text-decoration styles for the comment edit link, adding this helps us ensure consistent design tools across blocks.

How?

  • Opts into text decoration support.
  • Makes font size a default control

Testing Instructions

  1. Load the block editor with a post containing comments
  2. Add a comments block to the post and select the comment's edit link
  3. Confirm font size is now displayed by default
  4. Confirm the text decoration control is now available within the Typography panel's ellipsis menu
  5. Experiment with the typography settings
  6. Save and confirm the styles appear on the frontend
  7. Test the new support works for the block via theme.json and global styles.

Screenshots or screencast

Screen.Recording.2022-08-16.at.8.38.27.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 16, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 16, 2022
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-08-17 at 11 10 43 am

✅ All typography controls are available in the panel's ellipsis menu for the comment edit link
✅ Comment edit link typography styles appear correctly in editor and frontend (block and classic themes)
✅ Tested typography for comment edit link block in theme.json and global styles.

@aaronrobertshaw aaronrobertshaw merged commit bd687a5 into trunk Aug 17, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-comment-edit-link branch August 17, 2022 01:40
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 17, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants