Packages: Update the minimum required Node.js version to 14 for tools #43141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
update/tools-node-14
branch
from
dc0f362
to
fd92d05
Compare
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
gziolo
changed the title
gziolo
added
[Type] Build Tooling
|
Size Change: +414 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Aug 11, 2022
There was a problem hiding this comment.
Thanks for this, @gziolo! It looks awesome!
I just wasn't sure about the criteria we used when deciding which package to bump and which not to. Could you elaborate on that part?
I've also left a couple more questions. LMK what you think!
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR update the minimum required Node.js version to 14 for tools.
Why?
Node.js is no longer supporting v12. Let's update npm packages used directly with Node.js to require at least v14 according to the Long Term Support (LTS) schedule.
Support for Node v12 prevents us from using the most recent JavaScript syntax like optional chaining. The most recent example would be with #41642.
How?
Update
enginesfield inpackage.jsonfiles to require Node.js v14+.We should also stop running GitHub workflows with Node 12.
Testing Instructions
Everything should work as before with Node.js 14 and newer.