Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Release v1.79.0 #42239

Merged
merged 50 commits into from
Jul 8, 2022
Merged

Mobile Release v1.79.0 #42239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
6ea1d57
Release script: Update react-native-editor version to 1.76.0
jhnstn May 11, 2022
bcddcbc
Release script: Update with changes from 'npm run core preios'
jhnstn May 11, 2022
678bd2f
Update Changelog
jhnstn May 11, 2022
21b838c
Release script: Update react-native-editor version to 1.76.1
May 20, 2022
7f79f52
Release script: Update with changes from 'npm run core preios'
May 20, 2022
981471e
[Mobile] - BlockList - Add internal onLayout from CellRendererCompone…
May 18, 2022
0087e3d
[Mobile] - Fix Drag & Drop Chip positioning issue with RTL languages …
May 18, 2022
5c6fe0d
[RNMobile] Add drag & drop help guide in Help & Support screen (#40961)
fluiddot May 19, 2022
09d4368
[RNMobile] Fix drag mode not being enabled when long-pressing over Sh…
fluiddot May 20, 2022
c951e59
Mobile - Update changelog
May 20, 2022
d0b2cea
Translate NEW badge in Move blocks help screen
fluiddot May 20, 2022
132bc3a
Release script: Update react-native-editor version to 1.77.0
May 24, 2022
cb4105f
Release script: Update with changes from 'npm run core preios'
May 24, 2022
639598f
[RNMobile] Improve text read by screen readers for BottomSheetSelectC…
May 13, 2022
3fe5683
[RNMobile] Add 'Insert from URL' option to Image block (#40334)
derekblank May 23, 2022
a6dd494
[RNMobile] - E2E Simplify heading and lists blocks functions (#40670)
jostnes May 16, 2022
1b3391e
Add ruby version file (#41013)
jhnstn May 12, 2022
148f835
[RNMobile] Improvements to Getting Started Guides (#40964)
May 23, 2022
a046a61
update expected html for file block (#41300)
jostnes May 25, 2022
ede6624
Add waitForVisible() to all blocks (#41126)
jostnes May 25, 2022
2daf775
Update CHANGELOG
May 26, 2022
d8fbfbd
Revert "update expected html for file block (#41300)"
May 26, 2022
efc0f2c
[RNMobile] Ensure post title gets focused when is notified from nativ…
fluiddot May 26, 2022
4c714af
Release script: Update react-native-editor version to 1.77.1
fluiddot Jun 2, 2022
9365c4e
Release script: Update with changes from 'npm run core preios'
fluiddot Jun 2, 2022
ad2c8e4
[RNMobile] Bump `react-native-reanimated` version to `2.4.1-wp-3` (#4…
fluiddot Jun 2, 2022
f10a378
Update react-native-editor changelog
fluiddot Jun 2, 2022
4cfbd82
Release script: Update react-native-editor version to 1.78.0
fluiddot Jun 10, 2022
5b447b4
Release script: Update with changes from 'npm run core preios'
fluiddot Jun 10, 2022
8bd8d90
[RNMobile] Bump `react-native-gesture-handler` to version `2.3.2` (#4…
fluiddot May 27, 2022
bdaaf6e
Update react-native-editor changelog
fluiddot Jun 10, 2022
6e13c9e
Release script: Update react-native-editor version to 1.78.1
Jun 16, 2022
32ab484
Release script: Update with changes from 'npm run core preios'
Jun 16, 2022
4ae461c
[RNMobile] Gallery block: Re-introduce `v1` (#41533)
fluiddot Jun 14, 2022
01adee1
[RNMobile] Fix missing translations for locales that include region (…
fluiddot Jun 14, 2022
b1352b7
Update CHANGELOG
Jun 16, 2022
77417b6
Release script: Update react-native-editor version to 1.79.0
dcalhoun Jul 7, 2022
4e35a9d
Release script: Update with changes from 'npm run core preios'
dcalhoun Jul 7, 2022
2f31836
[RNMobile] Add integration tests to cover Drag & Drop functionality (…
fluiddot May 31, 2022
fb5f7e4
[Mobile] - Add E2E tests for the Drag & Drop blocks feature (#41368)
May 31, 2022
aee2a06
Mobile - Skip some of the Drag & Drop E2E on iOS (#41529)
Jun 3, 2022
c7a740c
where it can change to use clickIfClickable(), add new param for wait…
jostnes Jun 2, 2022
83444ec
[RNMobile] Add 'Insert from URL' option to Video block (#41493)
derekblank Jun 9, 2022
d407e8f
Upgrade Aztec to v1.5.9 (#41828)
derekblank Jun 22, 2022
720843b
fix: Image block preserves alt text from media library (#41839)
dcalhoun Jun 23, 2022
94e8c68
[RNMobile] Implement recovery option for invalid blocks (#41988)
Jul 4, 2022
95a1894
docs: Update change log
dcalhoun Jul 7, 2022
c9c1e6b
[RNMobile] Upgrades Gradle to 7.4.2 & Android Gradle Plugin to 7.2.1 …
oguzkocer Jul 7, 2022
581fc70
Update Aztec-Android version to v1.6.0 (#42243)
oguzkocer Jul 7, 2022
912b257
Merge branch 'trunk' of github.com:WordPress/gutenberg into rnmobile/…
dcalhoun Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-aztec/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-aztec",
"version": "1.78.1",
"version": "1.79.0",
"description": "Aztec view for react-native.",
"private": true,
"author": "The WordPress Contributors",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-bridge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-bridge",
"version": "1.78.1",
"version": "1.79.0",
"description": "Native bridge library used to integrate the block editor into a native App.",
"private": true,
"author": "The WordPress Contributors",
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For each user feature we should also add a importance categorization label to i

## Unreleased

## 1.79.0
- [*] Add 'Insert from URL' option to Video block [#41493]
- [*] Image block copies the alt text from the media library when selecting an item [#41839]
- [*] Introduce "block recovery" option for invalid blocks [#41988]
Expand Down
20 changes: 10 additions & 10 deletions packages/react-native-editor/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ PODS:
- ReactCommon/turbomodule/core (= 0.66.2)
- fmt (6.2.1)
- glog (0.3.5)
- Gutenberg (1.78.1):
- Gutenberg (1.79.0):
- React-Core (= 0.66.2)
- React-CoreModules (= 0.66.2)
- React-RCTImage (= 0.66.2)
Expand Down Expand Up @@ -337,7 +337,7 @@ PODS:
- React-Core
- RNSVG (9.13.6):
- React-Core
- RNTAztecView (1.78.1):
- RNTAztecView (1.79.0):
- React-Core
- WordPress-Aztec-iOS (~> 1.19.8)
- WordPress-Aztec-iOS (1.19.8)
Expand Down Expand Up @@ -503,7 +503,7 @@ SPEC CHECKSUMS:
FBReactNativeSpec: 18438b1c04ce502ed681cd19db3f4508964c082a
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
glog: 5337263514dd6f09803962437687240c5dc39aa4
Gutenberg: 214a8fe3bb352b754d9909d2bef764cd8289d1be
Gutenberg: 03d969bd5acf0f2787b81fd83a9af36efecaaee9
RCT-Folly: a21c126816d8025b547704b777a2ba552f3d9fa9
RCTRequired: 5e9e85f48da8dd447f5834ce14c6799ea8c7f41a
RCTTypeSafety: aba333d04d88d1f954e93666a08d7ae57a87ab30
Expand All @@ -518,12 +518,12 @@ SPEC CHECKSUMS:
React-logger: faee236598b0f7e1a5e3b68577016ac451f1f993
react-native-blur: ef741a08d020010ba65e411be0ab82d1d325e7ad
react-native-get-random-values: b6fb85e7169b9822976793e467458c151c3e8b69
react-native-keyboard-aware-scroll-view: 0bc6c2dfe9056935a40dc1a70e764b7a1bbf6568
react-native-keyboard-aware-scroll-view: 374b637c8684d7de50bd930df1a2d2b8fd49daa5
react-native-safe-area: c9cf765aa2dd96159476a99633e7d462ce5bb94f
react-native-safe-area-context: f0906bf8bc9835ac9a9d3f97e8bde2a997d8da79
react-native-safe-area-context: e471852c5ed67eea4b10c5d9d43c1cebae3b231d
react-native-slider: d4c3367c5db5d2bec3ac0ab9d15ebb73d896034c
react-native-video: 0b09cc469df0249509def5dc1484e0419342de9b
react-native-webview: 193d233c29eacce1f42ca2637dab7ba79c25a6de
react-native-video: 2ad952d1a9ce83e058dcb4a1800af3a99cb7edee
react-native-webview: 1f56115845c98f0a59dfbbac685797c014a821be
Comment on lines +521 to +526
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why the checksums have changed for these libraries if only we updated the version of Gutenberg and RNTAztecView 🤔. I've checked the Podfile.lock file changes in the previous release (reference) and looks like only Gutenberg and RNTAztecView changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated my PR and it brings back these references so I can restore them once I merge it, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated my PR and it brings back these references so I can restore them once I merge it, what do you think?

Yeah, sounds good, let's bring them back on that PR as it will be merged soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that these types of changes are related to #32772 (comment), and are merely a result of pod install on different development machines with different paths. It might be a good practice to avoid committing this type of change to avoid confusion, however I do not know if one value is "correct."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that these types of changes are related to #32772 (comment), and are merely a result of pod install on different development machines with different paths.

Great, thanks for sharing the context. I'm wondering what's the difference between our machines 🤔. I see Ceyhun outlined in that comment a potential workaround, so it might be interesting to tackle that in the future.

It might be a good practice to avoid committing this type of change to avoid confusion, however I do not know if one value is "correct."

Yep, it's not clear which values are the "correct" ones. I guess something that could be used as a guide in release PRs is that only Gutenberg and RNTAztecView Pods should be updated, wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's not clear which values are the "correct" ones. I guess something that could be used as a guide in release PRs is that only Gutenberg and RNTAztecView Pods should be updated, wdyt?

Yes, that would likely be helpful guidance. Unnecessary Podfile.lock changes could still sneak in within non-release PRs, but guidance for releases is likely still beneficial.

React-perflogger: 5ab487cacfe6ec19bfe3d3f8072bf71eb07d63da
React-RCTActionSheet: 03f25695e095fb5aa003828620943c74cc281fec
React-RCTAnimation: eaf82da39f0c36fb0ef2a28df797c5f73a2a98ea
Expand All @@ -536,13 +536,13 @@ SPEC CHECKSUMS:
React-RCTVibration: 3e815c3d2dd2e0e931b68595b5b92d23ba38b3fb
React-runtimeexecutor: 393e26602c1b248683372051e34db63e359e3b01
ReactCommon: c0263c1a41509aeb94be3214fa7bc3b71eae5ef6
RNCClipboard: 99fc8ad669a376b756fbc8098ae2fd05c0ed0668
RNCMaskedView: c298b644a10c0c142055b3ae24d83879ecb13ccd
RNCClipboard: f49f3de56b40d0f4104680dabadc7a1f063f4fd4
RNCMaskedView: d367b2a8df3992114e31b32b091a0c00dc800827
RNGestureHandler: 3b13cc25407d1cdbee33b6ae65790a55c032d2a9
RNReanimated: b413cc7aa3e2a740d9804cda3a9396a68f9eea7f
RNScreens: 953633729a42e23ad0c93574d676b361e3335e8b
RNSVG: 36a7359c428dcb7c6bce1cc546fbfebe069809b0
RNTAztecView: 57ebf9512a9318d4dfd9099dc290b11ad4b5ece6
RNTAztecView: 48124f42ccc72c4b00a5aa4982ee3a816860b7c3
WordPress-Aztec-iOS: 7d11d598f14c82c727c08b56bd35fbeb7dafb504
Yoga: 9a08effa851c1d8cc1647691895540bc168ea65f

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-editor",
"version": "1.78.1",
"version": "1.79.0",
"description": "Mobile WordPress gutenberg editor.",
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
Expand Down