Site Editor: Make Code Editor reflect block conversions #42081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature] Code Editor
|
Size Change: +22 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
Wow! Incredible work debugging this! I tested and it works as expected, but I have a question, is it a default behavior that it does not enable the Save button after the code update? This way it changes, but, if the user does not make any changes, the code won't be updated on the DB.
|
Yeah, I think this behavior is normal. Maybe it should be different, but if you try e.g. #40506 Fortunately, it’s not too much of a problem — we expect the un-converted block to continue to work, so if the user doesn’t end up making any changes to the template (or post) and thus cannot save it, it will remain the same on the frontend (which should continue to work) — basically until the user finally makes some change and saves the updated template (or post). FWIW, on a technical level, I believe this happens because we're not creating a new undo level upon block parsing (from where deprecations are run); I think the relevant LOC is this: |
|
It would be nice to get some feedback from @jorgefilipecosta. |
ockham
commented
Jul 5, 2022
| ? contentStructure( { blocks } ) | ||
| : contentStructure; | ||
|
|
||
| // Replicates the logic found in getEditedPostContent(). |
There was a problem hiding this comment.
Specifically:
gutenberg/packages/editor/src/store/selectors.js
Lines 895 to 901 in 6465552
There was a problem hiding this comment.
It would be nice to get some feedback from @jorgefilipecosta.
The change looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix #41944 (and potentially unblock #40506).
Why?
If a block is undergoing a legacy block conversion upon loading in the Site Editor, and the user then switches to the Code Editor, that conversion is not reflected there. See #41944 for details.
(This might also affect block deprecations.)
How?
By using the readily parsed (and thus, converted) blocks as the source of truth for the Code Editor, rather than the
contentstate.Testing Instructions
This requires a bit of fiddling to test, since in order to run a legacy block conversion, we need a template that includes a legacy block. Try the following:
First of all, verify that the problem exists on
trunkby using the instructions from #41944.Now, verify that this PR solves the problem:
wp:comments), save the template, and switch back totrunk.wp:comments-query-loop.update/rename-comments-query-loopbranch.wp:commentsthere ✅