Remove the Template panel option from the Preferences modal #42030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Task
|
Size Change: -13 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Jun 29, 2022
|
Hey George, thanks for the PR! I think that even if the |
I'm not sure. The Template setting isn't a separate panel anymore; using panel preferences here seems odd. @noisysocks, what do you think? |
|
This was the approach in #39973 for other panels like |
|
I'm not sure I understand the motivation behind these settings at all if I'm honest. Is it for extenders that want to simplify the UI for clients? Or for users that want a simpler writing experience? I feel both of these use cases are better served via different means, e.g. programmatic APIs for extenders and distraction free writing mode for users. So, that is to say, I personally don't think we need to keep the setting. But I'll defer to @javierarce as he's been design lead on the effort to redesign the document settings sidebar. |
|
This is how @shaunandrews (here) and I (here) had originally thought users could manage those settings: Screen.Recording.2022-06-30.at.22.20.02.movI think the location is quite handy, but now I'm not sure if that placement makes sense for a global setting that would affect other posts. |
|
We ended up landing on combining the Summary and Publish settings panels so that there is just Summary, no? I think it would be a bit too much to have those settings in the menu as well as the other actions we intend on adding there.
|
|
I'm thinking of merging this since the current option doesn't work, and it would be nice to cherry-pick the fix for 13.6. We can work on the new preferences for the Summary panel separately. |
|
Yeah agreed. No sense having a checkbox that doesn't do anything in 13.6. |
This was referenced Jul 13, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR remove the Template panel option from the Preferences modal
Why?
Now that Template settings are part of the Summary panel (#41925), this preference has no effect.
Testing Instructions
Screenshots or screencast