ESLint: Enable ignoreRestSiblings option for no-unused-vars rule
#41897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +148 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
update/eslint-no-unused-vars-ignore-rest-siblings
branch
from
ca4190c
to
b8cf990
Compare
This was referenced Jun 23, 2022
tyxla
force-pushed
the
update/eslint-no-unused-vars-ignore-rest-siblings
branch
from
b8cf990
to
06896d7
Compare
mirka
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Thought I'd leave it up for discussion, but looks like no one is opposed (yet)! I guess we can land it then. It's probably good to have in place, given that this is a common pattern and we won't have the Lodash omit as an escape hatch anymore.
I think we can forgo a components changelog for this one, but I'd say it's worth mentioning in the eslint-plugin changelog.
Good call, added one.
Well, I'll leave it up for now, and land it next week so if anyone has objections they can raise them in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR enables the
ignoreRestSiblingsoption of theno-unused-varsESLint rule in order to allow for declaring unused variables when using spread during destructuring. Previously, we had to ignore that rule to allow this, so this PR cleans those ignores up as well.Why?
Declaring a variable in order to spread the rest of the object during destructuring is a common way to omit properties out of objects in modern JavaScript and it should be allowed by our linter.
This came up in a review by @mirka here: #41865 (comment)
How?
We're specifically enabling the
ignoreRestSiblingsoption for theno-unused-varsrule, and removing all prior rule ignore comments that are no longer necessary.Testing Instructions
Question
@ciampo @mirka we're removing a couple of ESLint rule ignore comments from the components package - does this need a CHANGELOG entry? Let me know, and I'm happy to add one.