Search block: remove double spaces

[scruffian]

What?

Removes double spaces from the class names in the Search block. Fixes #41608

Why?

Not sure!

How?

Makes $block_classes an array, not a string so they can be output using implode.

Testing Instructions

• Add the search block to a post
• Check the markup of the block and ensure there's only one space between each class name.

[dmsnell]

Really like the change and the move towards a data model that more closely reflects the reality of what we're dealing with.

Apart from removing the var_dump() this looks like a good simple patch to apply.

One alternative we could have also explored (and maybe you did) is leave the concatenation the way it was but do a syntactic cleanup where we're currently implode()ing:

esc_attr( preg_replace( '~\s+~', ' ', $button_classes ) )

[scruffian]

One alternative we could have also explored (and maybe you did) is leave the concatenation the way it was but do a syntactic cleanup where we're currently implode()ing:

The reason I prefer the array is that, as you say, it represents "a data model that more closely reflects the reality of what we're dealing with."!

[dmsnell]

All clear!