Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Style engine: add elements and states to the backend #41619

Closed
wants to merge 14 commits into from
Closed

[WIP] Style engine: add elements and states to the backend #41619

wants to merge 14 commits into from

Commits on Jun 15, 2022

  1. Initial commit.

    @ramonjd
    ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    f0b30b5 View commit details
    Browse the repository at this point in the history

  2. Lint and other stuff zzzz

    @ramonjd
    ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    127bc76 View commit details
    Browse the repository at this point in the history

  3. Removed unused value_func

    @ramonjd
    ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    4ced1d5 View commit details
    Browse the repository at this point in the history

  4. Testing adding button element and transition states. 

    Do not merge!
This commit has highlighted the need to possibly allow certain CSS props via safecss_filter_attr
    @ramonjd
    ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    caeade2 View commit details
    Browse the repository at this point in the history

  5. Add support for focus for links and disabled for buttons

    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    a741fae View commit details
    Browse the repository at this point in the history

  6. Update tests to assert on focus and disabled state styles

    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    2608e32 View commit details
    Browse the repository at this point in the history

  7. DRY up by dynamically generating state definitions

    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    862ef25 View commit details
    Browse the repository at this point in the history

  8. Hack: Filter safe CSS rules to enable transition

    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    94e3a78 View commit details
    Browse the repository at this point in the history

  9. Update data model to remove the states key

    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    f98e4c8 View commit details
    Browse the repository at this point in the history

  10. Simplify: remove transitions 

    Let’s tackle this in a separate PR
    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    9448577 View commit details
    Browse the repository at this point in the history

  11. Remove everything that is not a link with :hover 

    Initial version should only support :hover on link. We can iteratively add support for more functionality once the elements API is upgraded.
    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    a0037a0 View commit details
    Browse the repository at this point in the history

  12. Remove changes to file

    @getdave @ramonjd
    getdave authored and ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    66a0276 View commit details
    Browse the repository at this point in the history

  13. Remove button element from definition list. 

    Reinstated tests
A bit of tidying up.
    @ramonjd
    ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    037b923 View commit details
    Browse the repository at this point in the history

  14. Updating elements to account for the fact that the style engine contr… 

    …ols which elements we support.
    @ramonjd
    ramonjd committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    99d836f View commit details
    Browse the repository at this point in the history