Update the minimum WP version to 5.9 #41306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Gutenberg Plugin
youknowriad
requested review from
TimothyBJacobs,
spacedmonkey and
geriux
as code owners
|
Size Change: -31 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
May 25, 2022
|
The Gallery block code changes all look good to me, and testing locally all the gallery functionality including transforms and deprecations works as expected. @fluiddot are you able to confirm if there are any problems with removing the mobile v1 gallery block code at this point? |
Thanks for the ping @glendaviesnz 🙇 ! The native version is bundled within the WordPress app, so we don't have a mechanism for dropping support for features by the WordPress version. This means that if we remove the v1 of the gallery block, users that are still using older versions of WordPress (i.e. WordPresss 5.8 and older) will be affected by this change and the Gallery block won't work properly for them. Eventually, we could remove the v1 but only once we know that most users are using the new version. Hence, let me check first the usage metrics and share the results. NOTE: I've done a quick check, and looks like we still have around |
|
Thanks for the detailed check on this @fluiddot. Is the easiest approach to revert the gallery native file changes and just keep the web v1 removals in this PR? |
Yep, if it's possible and until we decide whether we remove the |
Heads up that we finally decided to re-introduce support for |
|
Where are we at with getting this merged? We're coming up on a month post 6.0 release so I'd like to ensure this gets updated :) |
10 tasks
ntsekouras
force-pushed
the
update/minimum-wp-version-59
branch
from
d999f93
to
98973a6
Compare
|
I rebased now but it has some wrong files regarding the |
The native version still requires the |
ntsekouras
force-pushed
the
update/minimum-wp-version-59
branch
2 times, most recently
from
4a243f3
to
27ffd90
Compare
ntsekouras
reviewed
Jun 29, 2022
ntsekouras
force-pushed
the
update/minimum-wp-version-59
branch
from
3945663
to
421ef36
Compare
ntsekouras
force-pushed
the
update/minimum-wp-version-59
branch
from
421ef36
to
cad0e84
Compare
gziolo
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
I would appreciate some additional checks for changes applied to WP_Theme_JSON_Resolver_ classes from @scruffian who helped with this PR, but otherwise, all other code changes look great in my opinion.
I'm taking it now for a spin to ensure that everything continues to work also in my test environment. It would be great to have more folks doing sanity checks but we are also at the beginning of the next development cycle for the Gutenberg plugin so we will have 3 weeks to catch potential issues.
|
I did an extensive round of testing and I haven't discovered any issues. I tested:
|
1 task
This was referenced Jul 22, 2022
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now that WordPress 6.0 is out, the minimum version for the Gutenberg plugin should be updated to 5.9
How?
This is composed of two main changes:
Testing Instructions