[Site Editor]: Update single default template copy
#41302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Full Site Editing
[Feature] Site Editor
ntsekouras
requested review from
adamziel,
Mamaduka,
youknowriad,
scruffian,
gziolo and
jameskoster
ntsekouras
commented
May 25, 2022
| ), | ||
| 'single' => array( | ||
| 'title' => _x( 'Single', 'Template name', 'gutenberg' ), | ||
| 'description' => __( 'Displays any single post type.', 'gutenberg' ), |
There was a problem hiding this comment.
Here are the actual changes for single template.
|
The description is tricky. It would be good to indicate the relationship between this template and the more specific alternatives. For reference here's what we have currently in #41189 for single-$posttype:
Perhaps something like:
What do you think? |
Mamaduka
reviewed
May 25, 2022
ntsekouras
force-pushed
the
update/single-default-template-copy
branch
from
55d1b4b
to
a9a59b9
Compare
Co-authored-by: George Mamadashvili <[email protected]>
|
It makes sense to me but it might be good to get input from themers :) |
youknowriad
pushed a commit
that referenced
this pull request
May 26, 2022
* [Site Editor]: Update single default template copy * Update lib/compat/wordpress-6.1/block-template-utils.php Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: George Mamadashvili <[email protected]>
37 tasks
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 8, 2022
In order to add more template types we need to update some copy from the current default templates provided. This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy] Follow-up to [52062], [52331]. Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian. Fixes #56534. Built from https://develop.svn.wordpress.org/trunk@54104 git-svn-id: http://core.svn.wordpress.org/trunk@53663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Sep 8, 2022
In order to add more template types we need to update some copy from the current default templates provided. This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy] Follow-up to [52062], [52331]. Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian. Fixes #56534. Built from https://develop.svn.wordpress.org/trunk@54104 git-svn-id: https://core.svn.wordpress.org/trunk@53663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pbearne
pushed a commit
to pbearne/wordpress-develop
that referenced
this pull request
Sep 9, 2022
In order to add more template types we need to update some copy from the current default templates provided. This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy] Follow-up to [52062], [52331]. Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian. Fixes #56534. git-svn-id: https://develop.svn.wordpress.org/trunk@54104 602fd350-edb4-49c9-b593-d223f7449a82
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
In order to add more template types we need to update some copy from the current default templates provided. This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy] Follow-up to [52062], [52331]. Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian. Fixes #56534. Built from https://develop.svn.wordpress.org/trunk@54104
30 tasks
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
In order to add more template types we need to update some copy from the current default templates provided. This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy] Follow-up to [52062], [52331]. Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian. Fixes #56534. git-svn-id: https://develop.svn.wordpress.org/trunk@54104 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #37407
Needed for: #41189
In order to add more template types we need to update some copy from the current default templates provided.
This PR intents to update the
singletemplate copy as it's needed to clear up ambiguity between thesingletemplate that is the fallback for any custom post type(includingpost) and the menu item to be added in the linked PR, that will allow the creation thesingle-posttemplate and anysingle_$post_typetemplate.Testing Instructions
Add newbutton to create a new templateSingle Postmenu item has new copyImportant Everything else should work as expected without any regression. This includes the existing themes/templates, creation flow, resolution of templates, etc..