Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Improve text read by screen readers for BottomSheetSelectControl #41036

Merged
merged 3 commits into from
May 13, 2022
Merged

[RNMobile] Improve text read by screen readers for BottomSheetSelectControl #41036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c677a5
Enable control's label to be read by screen reader
May 12, 2022
16ac9ad
Update CHANGELOG
May 12, 2022
4f9fd30
Update CHANGELOG for clarity
May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/components/src/mobile/bottom-sheet-select-control/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,16 @@ const BottomSheetSelectControl = ( {
value={ selectedOption.label }
onPress={ openSubSheet }
accessibilityRole={ 'button' }
accessibilityLabel={ selectedOption.label }
accessibilityLabel={ sprintf(
// translators: %1$s: Select control button label e.g. "Button width". %2$s: Select control option value e.g: "Auto, 25%".
__( '%1$s. Currently selected: %2$s' ),
label,
selectedOption.label
) }
accessibilityHint={ sprintf(
// translators: %s: Select control button label e.g. "Button width"
__( 'Navigates to select %s' ),
selectedOption.label
label
) }
>
<Icon icon={ chevronRight }></Icon>
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For each user feature we should also add a importance categorization label to i

## Unreleased

- [*] [a11y] Improve text read by screen readers for BottomSheetSelectControl [#41036]

## 1.76.0

Expand Down