Post Comments: Add Warning via editor.BlockEdit filter #40898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
the
[Block] Comments (legacy)
ockham
force-pushed
the
update/move-post-comments-warning-into-block-edit-filter
branch
from
b4dbb6b
to
64d3ca6
Compare
|
Size Change: +287 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ockham
force-pushed
the
update/move-post-comments-warning-into-block-edit-filter
branch
from
64d3ca6
to
efaee33
Compare
ockham
commented
May 9, 2022
| @@ -46,6 +46,7 @@ | |||
| "@wordpress/date": "file:../date", | |||
| "@wordpress/deprecated": "file:../deprecated", | |||
| "@wordpress/dom": "file:../dom", | |||
| "@wordpress/editor": "file:../editor", | |||
There was a problem hiding this comment.
This is probably the major downside of this PR 😬 In the past, we've been keen to avoid having the blocks depend on the editor.
As for the reason for this change, see this inline comment: https://github.com/WordPress/gutenberg/pull/40898/files#diff-e1efd67de68dbd5ce8acea06af13216e3c2455c7b87c16d31cea7df4f282a9fbR209-R211
|
@michalczaplinski pointed out in #40536 (comment):
|
|
Closing in favor of #40868 😄 |
ockham
deleted the
update/move-post-comments-warning-into-block-edit-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Purports to fix both #40536 and #40826.
Why?
To fix those issues 😬
How?
As explained in #40536 (comment),
Testing Instructions
Screenshots or screencast
TODO
postIdandpostType(since block context isn't available to the filter we're using)