[Automated Testing]: Fix partial selection copy flaky tests #40607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Type] Automated Testing
|
Thanks! I noticed that some tests below also have the similar code, do we want to also add them there? |
|
Size Change: +13 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
I don't think is needed right now, as they always succeed and are |
I actually tried that without the custom
Hence, I think we probably still need them and they only succeed only by chance (or some other reasons 😅).
I forgot the details but IIRC it has something to do with the native clipboard event/keybinding doesn't work in headless mode. |
kevin940726
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #40307
Fixes: #40303
Fixes partial selection flaky tests caused by intermittent proper placement of the caret.