Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding schema info to theme.json reference #40599

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

annezazu
Copy link
Contributor

What?

Received feedback from a developer that including a reference to the theme.json schema would go a long way as it's common for developers to rely on a reference over a how to guide. It does not include the GIF as that feels distracting in this more straightforward doc.

Why?

To save folks time and connect dots around the schema that's available.

How?

By updating the docs for theme.json reference to include the same info as seen here: https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-json/#developing-with-theme-json

Received feedback from a developer that including a reference to the theme.json schema would go a long way as it's common for developers to rely on a reference over a how to guide.
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Type] Developer Documentation Documentation for developers labels Apr 25, 2022
Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carolinan carolinan merged commit aa1304e into trunk Apr 26, 2022
@carolinan carolinan deleted the annezazu-schema-update branch April 26, 2022 12:27
@github-actions github-actions bot added this to the Gutenberg 13.2 milestone Apr 26, 2022
@gziolo
Copy link
Member

gziolo commented Apr 30, 2022

Excellent addition ❤️

Do we have a similar note for the block.json file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants