Post terms: Add prefix & suffix

[dsas]

What?

Allowing an optional prefix and suffix to be added to the Post Categories and Post Tags

Why?

A common pattern in themes is to display categories and tags prepended with a text. This is the case for all default themes, including TwentyTwentyOne.

Fixes #29909

How?

• Add prefix and suffix attributes to the post-terms block.
• Allow these attributes to be set inside the block editor via a RichText component

Testing Instructions

1. Open a Post or page
2. Insert a Post Tags or Post Categories block
3. Click the placeholder and start typing
4. Press Publish
5. Look at the site on the frontend

Screenshots or screencast

Screen.Capture.on.2022-04-22.at.21-22-18.mp4

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @dsas! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[carolinan]

Editing the placeholders works well in my test, the toolbar options also work and the text displays as expected on the front.

Are these terms, prefix and suffix, common enough to be understood by most users?

In my opinion, to allow theme developers to style the prefix and suffix, the markup in the editor and front needs to match and the class names wp-block-post-terms__suffix and wp-block-post-terms__prefix should be used both in the editor and the front.
I think that extensibility will be important, even though it means adding two more spans.

[dsas]

@carolinan thanks for the review, I've made the span change as suggested.

I think 'prefix' and 'suffix' are common enough, but as a native English speaking developer, perhaps I'm not the best person to answer! I don't think there is a simple alternative to 'prefix' and 'suffix' that's as recognisable. Perhaps 'preface' rather than prefix, but I'm not sure that's much clearer really. I'll continue to think about it, but if anyone has any suggestions, they're very welcome.

[Mamaduka]

Hi, @amustaque97

What method are you using to merge merging the PRs? Commits from this branch merged into trunk without squashing them into one.

It's not a big deal, I just wanted to check if this was an issue on the GitHub side.

[amustaque97]

Hi, @amustaque97

What method are you using to merge merging the PRs? Commits from this branch merged into trunk without squashing them into one.

It's not a big deal, I just wanted to check if this was an issue on the GitHub side.

Hi @Mamaduka 👋 , yeah I choose the other option without squashing them into one. I have noticed this behaviour for others, I can see it working correctly but in my case it somehow makes a single commit while merge.

Next time, I will record my screen and then probably we can discuss.

[Mamaduka]

@amustaque97, it's supposed to make a single commit on merge. So I would recommend always using the "Squash and merge" option.