Latest Posts Block: Hardcode class for post date

[Soean]

Description

The class for the post date in the Latest posts block should always be wp-block-latest-posts__post-date. Without this PR the class changes, when the user adds an additional class to the block.

[aduth]

The class for the post date in the Latest posts block should always be wp-block-latest-posts__post-date.

Hmm, my understanding of the className prop was that we didn't want block implementers to assume what the class name would be, in which case we'd want to avoid such hard-coding.

[Soean]

Its just the class for the date. The class is also hard-coded in the PHP file: https://github.com/WordPress/gutenberg/blob/update/latest-posts-postdate-class/blocks/library/latest-posts/index.php#L41

If I add an additional class xxx to the block, the date class changes from wp-block-latest-posts__post-date to wp-block-latest-posts xxx__post-date

[aduth]

Its just the class for the date. The class is also hard-coded in the PHP file: https://github.com/WordPress/gutenberg/blob/update/latest-posts-postdate-class/blocks/library/latest-posts/index.php#L41

Makes me wonder if it should. If we're providing utilities for save implementation in the client to assign a class name, should these same utilities not exist for a dynamic block's render?

[youknowriad]

What's the next step here? Add server side generated className to the render callback?

[danielbachhuber]

Closing per #4018 (comment)