Mobile - Rich Text - Validate link colors #38474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
8 tasks
fluiddot
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
LGTM 🎊 !
I confirm that the crash can't be reproduced, however, I noticed that adding 3 or more colors to the custom palette makes the default text color turn white which makes the text to be unreadable (see attached video capture).
android-custom-palette.mp4
Yeah, that's one of the issues that will be fixed in #38417. For now this will prevent the crash. Thanks for bringing it up and for the review! |
4 tasks
|
The changelog update will be included in #38488 |
SiobhyB
pushed a commit
that referenced
this pull request
Feb 3, 2022
* Mobile - Rich Text - Validate link colors * Mobile - Rich Text - Update naming to match prop
4 tasks
mchowning
added a commit
that referenced
this pull request
Feb 3, 2022
* Release script: Update react-native-editor version to 1.71.0 * Release script: Update with changes from 'npm run core preios' * Updare CHANGELOG to reflect changes in 1.71.0 * Tests: Enable post type UI for templates and template parts (#38486) * Tests: Enable post type UI for templates and template parts * Only enable UI for block themes * Mobile - Rich Text - Validate link colors (#38474) * Mobile - Rich Text - Validate link colors * Mobile - Rich Text - Update naming to match prop Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]> Co-authored-by: Matt Chowning <[email protected]>
mchowning
added a commit
that referenced
this pull request
Feb 11, 2022
* Release script: Update react-native-editor version to 1.71.0 * Release script: Update with changes from 'npm run core preios' * Updare CHANGELOG to reflect changes in 1.71.0 * Tests: Enable post type UI for templates and template parts (#38486) * Tests: Enable post type UI for templates and template parts * Only enable UI for block themes * Mobile - Rich Text - Validate link colors (#38474) * Mobile - Rich Text - Validate link colors * Mobile - Rich Text - Update naming to match prop * Release script: Update react-native-editor version to 1.71.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Highlight text: Check if style attribute value is defined during filtering (#38670) * Check if style value is defined before removing extra spaces * Add test case for old text color format * Update react-native-editor changelog * Update CHANGELOG with 1.71.1 changes * Fix incorrect CHANGELOG entry from previous commit Co-authored-by: Siobhan <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]> Co-authored-by: Carlos Garcia <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> Mobile - Rich Text - Validate link colors wordpress-mobile/gutenberg-mobile#4542Fixes wordpress-mobile/WordPress-Android#15876
Description
This PR fixes a crash on production for users using block-based themes and custom link colors, currently we don't support custom palettes and this is generating setting invalid link colors. On iOS it just simply uses the default color, but on Aztec Android, if an invalid color is passed through the
textattribute inRichTextit will crash the app when it tries to parse it.So to avoid this, it will validate if the color is correct, if not it'll pass the default editor value. Using the
colordlibrary to check the value.Testing Instructions
Precondition: A custom color palette, to create this follow these instructions:
Test case 1 (Change the default link color of your theme to a custom one)
Note: You won't see the link color you selected until we support custom palettes, this will be introduced here.
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).