Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duotone: Allow users to specify custom filters #38442

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Duotone: Allow users to specify custom filters #38442

merged 1 commit into from
Feb 2, 2022

Conversation

scruffian
Copy link
Contributor

Description

In order to allow themes to specify their own custom duotone filters, we need to allow SVG to be output for filters defined in the custom key of the Global Styles json object.

How has this been tested?

Use the Skatepark theme
Open the customizer and select a custom color
Check that images have duotone applied with the new colors

Screenshots

Screenshot 2022-01-18 at 16 30 00

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@scruffian scruffian added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Feb 2, 2022
@scruffian scruffian self-assigned this Feb 2, 2022
@scruffian scruffian mentioned this pull request Feb 2, 2022
Closed
8 tasks
@scruffian scruffian mentioned this pull request Feb 2, 2022
Closed
@scruffian scruffian merged commit 216d291 into trunk Feb 2, 2022
@scruffian scruffian deleted the add/custom-filters branch February 2, 2022 16:05
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 2, 2022
@oandregal
Copy link
Member

Labeling this to be part of the next minor as per this conversation #38416 (comment)

@oandregal oandregal added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Feb 4, 2022
@Mamaduka Mamaduka removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Feb 16, 2022
Mamaduka pushed a commit that referenced this pull request Feb 16, 2022
@scruffian @Mamaduka
Duotone: Allow users to specify custom filters (#38442)
7e94339
@Mamaduka Mamaduka mentioned this pull request Feb 16, 2022
Closed
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 17, 2022
@audrasjb
Editor: Backport Duotone fixes for 5.9.1.
4bdde1f 
This changeset is a backport for the following Gutenberg PRs:

- Fix duotone theme cache: WordPress/gutenberg#36236
- Fix duotone render in non-fse themes gutenberg: WordPress/gutenberg#37954
- Duotone: Allow users to specify custom filters gutenberg: WordPress/gutenberg#38442

Props oandregal, scruffian, Mamaduka.
Merges [52757] to the 5.9 branch.
See #55179.


git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52759 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 17, 2022
@audrasjb
Editor: Backport Duotone fixes for 5.9.1.
affb772 
This changeset is a backport for the following Gutenberg PRs:

- Fix duotone theme cache: WordPress/gutenberg#36236
- Fix duotone render in non-fse themes gutenberg: WordPress/gutenberg#37954
- Duotone: Allow users to specify custom filters gutenberg: WordPress/gutenberg#38442

Props oandregal, scruffian, Mamaduka.
Merges [52757] to the 5.9 branch.
See #55179.

Built from https://develop.svn.wordpress.org/branches/5.9@52759


git-svn-id: http://core.svn.wordpress.org/branches/5.9@52348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Feb 17, 2022
@audrasjb
Editor: Backport Duotone fixes for 5.9.1.
debe144 
This changeset is a backport for the following Gutenberg PRs:

- Fix duotone theme cache: WordPress/gutenberg#36236
- Fix duotone render in non-fse themes gutenberg: WordPress/gutenberg#37954
- Duotone: Allow users to specify custom filters gutenberg: WordPress/gutenberg#38442

Props oandregal, scruffian, Mamaduka.
Merges [52757] to the 5.9 branch.
See #55179.

Built from https://develop.svn.wordpress.org/branches/5.9@52759


git-svn-id: https://core.svn.wordpress.org/branches/5.9@52348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
whereiscodedude pushed a commit to whereiscodedude/wpss that referenced this pull request Sep 18, 2022
Editor: Backport Duotone fixes for 5.9.1.
6da04df 
This changeset is a backport for the following Gutenberg PRs:

- Fix duotone theme cache: WordPress/gutenberg#36236
- Fix duotone render in non-fse themes gutenberg: WordPress/gutenberg#37954
- Duotone: Allow users to specify custom filters gutenberg: WordPress/gutenberg#38442

Props oandregal, scruffian, Mamaduka.
Merges [52757] to the 5.9 branch.
See #55179.

Built from https://develop.svn.wordpress.org/branches/5.9@52759
VenusPR added a commit to VenusPR/Wordpress_Richard that referenced this pull request Mar 9, 2023
@VenusPR
Editor: Backport Duotone fixes for 5.9.1.
76186a2 
This changeset is a backport for the following Gutenberg PRs:

- Fix duotone theme cache: WordPress/gutenberg#36236
- Fix duotone render in non-fse themes gutenberg: WordPress/gutenberg#37954
- Duotone: Allow users to specify custom filters gutenberg: WordPress/gutenberg#38442

Props oandregal, scruffian, Mamaduka.
Merges [52757] to the 5.9 branch.
See #55179.

Built from https://develop.svn.wordpress.org/branches/5.9@52759


git-svn-id: http://core.svn.wordpress.org/branches/5.9@52348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajlende ajlende ajlende approved these changes

@oandregal oandregal Awaiting requested review from oandregal

@gziolo gziolo Awaiting requested review from gziolo

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees

@scruffian scruffian

Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Projects
None yet
Milestone
Gutenberg 12.6
Development

Successfully merging this pull request may close these issues.
4 participants
@scruffian @oandregal @ajlende @Mamaduka